Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: why unobserve/observe the document on changes? #38

Closed
fcollonval opened this issue Oct 4, 2022 · 2 comments · Fixed by #39
Closed

Question: why unobserve/observe the document on changes? #38

fcollonval opened this issue Oct 4, 2022 · 2 comments · Fixed by #39

Comments

@fcollonval
Copy link
Member

In JupyterLab front end, we are not doing that. Is it an artifact from an earlier version or a behavior difference in y_py compared to yjs?

https://github.com/jupyter-server/jupyter_server_ydoc/blob/d7e728b0c773977c6a307d7a8878b40c6be3a13d/jupyter_server_ydoc/ydoc.py#L250-L253

@welcome
Copy link

welcome bot commented Oct 4, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@davidbrochart
Copy link
Collaborator

Thinking more about it now, it might not be necessary indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants