Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populating the path property of the ydoc #341

Closed
brichet opened this issue Aug 29, 2024 · 0 comments · Fixed by #342
Closed

Populating the path property of the ydoc #341

brichet opened this issue Aug 29, 2024 · 0 comments · Fixed by #342
Labels
bug Something isn't working

Comments

@brichet
Copy link
Contributor

brichet commented Aug 29, 2024

Description

The path property of the ydoc is not populated.

This is probably a regression included in #174.
The path used to be set here:

self.room.document.path = file_path

Reproduce

Open a document in collaborative mode and try to get the path from the ydoc.

Expected behavior

The path to be populated.

Suggestion

Set the path should be trivial at initialization, i.e. at

self._document = YDOCS.get(self._file_type, YFILE)(self.ydoc)

Then we should probably update the path if it has changed, probably from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant