Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing / in repo URL is not stripped #1919

Closed
rgaiacs opened this issue Jan 28, 2025 · 1 comment · Fixed by #1921
Closed

Trailing / in repo URL is not stripped #1919

rgaiacs opened this issue Jan 28, 2025 · 1 comment · Fixed by #1921
Labels

Comments

@rgaiacs
Copy link
Contributor

rgaiacs commented Jan 28, 2025

This was first reported by @JuKo007.

Bug description

I believe that in the the old UI, BinderHub was stripping the leading / in the URL provided by the user. For example, if the user provides

https://github.com/gesiscss/Jupyter4NFDI_survey_results/

the UI would process as

https://github.com/gesiscss/Jupyter4NFDI_survey_results

How to reproduce

  1. Go to https://notebooks.gesis.org/ or https://2i2c.mybinder.org/
  2. Fill "URL" with https://github.com/gesiscss/Jupyter4NFDI_survey_results/

Expected behaviour

Launch URL to be

https://2i2c.mybinder.org/v2/gh/gesiscss/Jupyter4NFDI_survey_results/HEAD

Actual behaviour

Launch URL is

https://2i2c.mybinder.org/v2/gh/gesiscss/Jupyter4NFDI_survey_results//HEAD

Notice the //. This is making BinderHub to not be able to resolve the reference.

Image

@rgaiacs rgaiacs added the bug label Jan 28, 2025
@minrk minrk changed the title Leading / in URL is not strip Trailing / in repo URL is not stripped Jan 29, 2025
@rgaiacs
Copy link
Contributor Author

rgaiacs commented Jan 29, 2025

This is part of #1920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant