Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add await for postShape before sending #351

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Add await for postShape before sending #351

merged 3 commits into from
Apr 19, 2024

Conversation

gjmooney
Copy link
Contributor

Wait for the GLTFExporter callback to populate postShape before sending postResult to worker threads.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytercad/gltf-support-await

martinRenou
martinRenou approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@martinRenou martinRenou added the bug Something isn't working label Apr 19, 2024
trungleduc
trungleduc requested changes Apr 19, 2024
View reviewed changes
packages/base/src/3dview/mainview.tsx Outdated Show resolved Hide resolved
martinRenou
martinRenou approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@trungleduc trungleduc merged commit 89eeabc into jupytercad:main Apr 19, 2024
9 checks passed
@gjmooney gjmooney deleted the gltf-support-await branch April 22, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjmooney @trungleduc @martinRenou