Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Panel sections not accessible at browser zoom #6559

Closed
Tracked by #6577
kulsoomzahra opened this issue Oct 7, 2022 · 6 comments · Fixed by jupyterlab/jupyterlab#13241 or #6627
Closed
Tracked by #6577

Running Panel sections not accessible at browser zoom #6559

kulsoomzahra opened this issue Oct 7, 2022 · 6 comments · Fixed by jupyterlab/jupyterlab#13241 or #6627
Labels
Milestone

Comments

@kulsoomzahra
Copy link

This issue was discovered during browser zoom audits.

Context

When Kernels section is expanded, it's hard to access other sections (like Language Server and Terminal) of the Running Panel.

Screencast-from-Saturday-08-October-2022-12_23_18-IST

Expected behavior
Our goal is to be able to reach other sections of the Running Panel like for e.g. in VS code.

VSCode.webm

To Reproduce
Steps to reproduce the behavior:

  1. Zoom to 400%
  2. Open a few notebooks
  3. Click on 'Running' tab
  4. Expand 'Kernels'
  5. Try to reach 'Language Server' or 'Terminal'

Desktop (please complete the following information):

  • OS: Linux (Ubuntu)
  • Browser: Chrome version 104.0.5112.101
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Oct 7, 2022
@kulsoomzahra
Copy link
Author

Hey! @jtpio
Are you aware of any plans to upstream the expand/collapse functionality of the Running Panel sections to JupyterLab?
I'm asking in an attempt to resolve an accessibility issue in JupyterLab. Thanks!

@jtpio jtpio added this to the 7.0 milestone Oct 8, 2022
@jtpio
Copy link
Member

jtpio commented Oct 8, 2022

Many thanks @kulsoomzahra for opening this issue and for the screenscasts 👍

Are you aware of any plans to upstream the expand/collapse functionality of the Running Panel sections to JupyterLab?

The Running Panel section in Notebook 7 is the same as the one JupyterLab. It was recently updated in jupyterlab/jupyterlab#13074, and Notebook 7 just reuses it as is.

So any fix to this component should be implemented upstream in JupyterLab. Which can then be pulled in Notebook 7 next time the JupyterLab dependency is updated.

@kulsoomzahra
Copy link
Author

@jtpio That's great, thanks!

@kulsoomzahra
Copy link
Author

Update-1
Something that I tried doing:

  1. Identify the .lm-AccordionPanel and put a scroll to it.
  2. Modified min-height:auto which helps to scroll the entire length of the .lm-AccordionPanel.
    (Previously it was 328px)

Current scenario:

Scroll.webm

@jtpio
Copy link
Member

jtpio commented Oct 11, 2022

Thanks @kulsoomzahra! Feel free to open a PR (even as a draft) in JupyterLab if you would like to suggest these fixes 👍

@kulsoomzahra
Copy link
Author

I've opened a PR in jupyterlab/jupyterlab#13241, @jtpio thanks for following up! :)

@jtpio jtpio linked a pull request Nov 18, 2022 that will close this issue
11 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants