-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save widget models with Execute preprocessor? #718
Comments
That seems reasonable but I'd need to see the implementation. I'd happily review a PR if you have a working model. |
Thanks. I haven't finished testing with nbsphinx but this works with the unit test I wrote: It doesn't remove default values like the proper notebook does. Do you know if there's some existing logic for doing that somewhere that can be reused? Or maybe it doesn't matter. |
@mpacer I've finished testing this and it's working in practice for building my documentation using nbsphinx -- I've made a PR if you have a chance to look. |
dup? #751 |
Most of the discussion is in #751, so I am closing this issue as the duplicate. |
I'm using a notebook & nbsphinx to document my custom widget. This works fine if I run the notebook by hand and explicitly "save widget state". But it doesn't work if I use nbsphinx to execute the notebook, because the execute preprocessor doesn't save widget states (comm messages are discarded here).
From a quick look it doesn't look like it would be too hard to dump these comm messages and save the
data
of the message into thewidgets
part of the notebook document. Is that a good idea?The text was updated successfully, but these errors were encountered: