Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate upgrading to pyppeteer 1.x #1707

Closed
bollwyvl opened this issue Jan 24, 2022 · 0 comments · Fixed by #1711
Closed

evaluate upgrading to pyppeteer 1.x #1707

bollwyvl opened this issue Jan 24, 2022 · 0 comments · Fixed by #1711

Comments

@bollwyvl
Copy link
Contributor

Elevator pitch

Raise the pin on pyppeteer to >=1,<1.1 from '==0.2.6'.

Motivation

A few 1.x releases have now gone out, and some time has elapsed to shake down any additional bugs. While a 1.x doesn't really mean anything, it seems like giving a package the benefit of the doubt that this will be a more stable API seems fair.

Especially if a major rev of nbconvert is on the horizon to support major revs of heavyweights like mistune (#1685) and mathjax (#1706), it would be good to get this one updated as well.

Additional context

Among the important things: at least its provisioning is no longer insecure-by-default, and requires up-to-date certificates. Its default chromium is still 588429, with claimed compatibility with puppeteer v1.6.0... but those haven't been updated in a long time. No telling what state it's actually in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant