-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark tests requiring network access #1526
Comments
Thanks for @mcepl ! And thanks for opening these across several projects. I agree that network requests during unittests is a bad idea. The chromium webpdf setup is a little annoying to both test the lazy download/install and not have network so we haven't had the time / energy to mock that interaction in a meaningful manner. I made a PR with your patch applied. Were there other test you saw that needed this marking beyond this? |
Just with this (and setting
|
All builds (and running test suites as part of them) of OpenSUSE packages (the same for every other Linux or Mac distribution) happen in the chrooted environment without the network access, which makes running of the test suite for this package extremely awkward. Most of tests fail because they require network access, which is a bad idea even for other reasons (mocking is the way to go).
skip_network_tests.patch is the solution of my problem, marking all tests requiring network access appropriately, and then skipping so marked ones.
The text was updated successfully, but these errors were encountered: