Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 removed 'pipes' module #308

Closed
0-wiz-0 opened this issue Oct 14, 2024 · 2 comments · Fixed by #286
Closed

Python 3.13 removed 'pipes' module #308

0-wiz-0 opened this issue Oct 14, 2024 · 2 comments · Fixed by #286
Labels
bug Something isn't working

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Oct 14, 2024

When building nbclassic with Python 3.13, the build fails due to its use of the pipes library.

* Building wheel...
Traceback (most recent call last):
  File "/usr/pkg/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
    main()
    ~~~~^^
  File "/usr/pkg/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 335, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
                             ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/pkg/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
    return _build_backend().build_wheel(wheel_directory, config_settings,
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                        metadata_directory)
                                        ^^^^^^^^^^^^^^^^^^^
  File "/usr/pkg/lib/python3.13/site-packages/jupyter_packaging/build_api.py", line 23, in build_wheel
    val = orig_build_wheel(
        wheel_directory,
        config_settings=config_settings,
        metadata_directory=metadata_directory,
    )
  File "/usr/pkg/lib/python3.13/site-packages/setuptools/build_meta.py", line 421, in build_wheel
    return self._build_with_temp_dir(
           ~~~~~~~~~~~~~~~~~~~~~~~~~^
        ['bdist_wheel'],
        ^^^^^^^^^^^^^^^^
    ...<3 lines>...
        self._arbitrary_args(config_settings),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/pkg/lib/python3.13/site-packages/setuptools/build_meta.py", line 403, in _build_with_temp_dir
    self.run_setup()
    ~~~~~~~~~~~~~~^^
  File "/usr/pkg/lib/python3.13/site-packages/setuptools/build_meta.py", line 318, in run_setup
    exec(code, locals())
    ~~~~^^^^^^^^^^^^^^^^
  File "<string>", line 52, in <module>
  File "/tmp/www/py-nbclassic/work/nbclassic-1.1.0/setupbase.py", line 15, in <module>
    import pipes
ModuleNotFoundError: No module named 'pipes'

ERROR Backend subprocess exited when trying to invoke build_wheel

pipes was obsoleted in Python 3 (yes, 3.0) and finally removed in 3.13.
You can probably use shlex instead.

@0-wiz-0 0-wiz-0 added bug Something isn't working status:Needs Triage labels Oct 14, 2024
@RRosio
Copy link
Collaborator

RRosio commented Oct 15, 2024

Thank you for opening this issue @0-wiz-0! This was fixed by #286, so now we are waiting on a release!

It should be fixed once that release is out!

@0-wiz-0
Copy link
Author

0-wiz-0 commented Oct 16, 2024

That's great, thank you! Looking forward to the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants