Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remains of jupyter bundlerextension #194

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Remove remains of jupyter bundlerextension #194

merged 1 commit into from
Mar 23, 2020

Conversation

m-rossi
Copy link
Contributor

@m-rossi m-rossi commented Mar 20, 2020

If you install or update jupyter_server after notebook the executable jupyter-bundlerextension will be overwritten because of the entrypoint defined in setup.py and the conda-forge-recipe. You will get the following error if you execute the following example command jupyter bundlerextension list

Traceback (most recent call last):
  File "/Users/USER/opt/anaconda3/bin/jupyter-bundlerextension", line 7, in <module>
    from jupyter_server.bundlerextensions import main
ModuleNotFoundError: No module named 'jupyter_server.bundlerextensions'

This can be fixed by reinstalling notebook with conda install notebook --force-reinstall, however this PR removes the remaining parts (left of #47) of the bundler from the codebase.

@Zsailer
Copy link
Member

Zsailer commented Mar 23, 2020

👍 This is fine for now.

I think we're going to keep the bundler in Jupyter Server (though there hasn't been any discussion around it, yet). That said, we'll need to rename the entrypoint and avoid colliding with notebook for a little while. If we do keep the bundler app in Jupyter Server, Notebook will lose the bundlerextensions entrypoint in favor of JS—or it at least it be shimmed to Jupyter Server;s bundler app.

In the meantime, removing the entrypoint here is fine. We'll need to create a new entrypoint in a future PR.

@Zsailer
Copy link
Member

Zsailer commented Mar 23, 2020

Thanks, @m-rossi! Merging.

@Zsailer Zsailer merged commit 3a75ada into jupyter-server:master Mar 23, 2020
@m-rossi m-rossi deleted the remove-bundler-remains branch March 23, 2020 17:00
ericpre added a commit to ericpre/jupyter_server-feedstock that referenced this pull request Jan 19, 2021
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* add git config to deployment

* add git config to deployment
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
…ains

Remove remains of jupyter bundlerextension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants