Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI workflow to test downstream projects #639

Closed
jtpio opened this issue Apr 12, 2021 · 2 comments · Fixed by #644
Closed

CI workflow to test downstream projects #639

jtpio opened this issue Apr 12, 2021 · 2 comments · Fixed by #644

Comments

@jtpio
Copy link
Member

jtpio commented Apr 12, 2021 •
edited
Loading

It would be nice to have a workflow running on CI to test potential breaking changes with downstream projects like jupyter_server and others.

Which could be similar to the one used by traitlets:

https://github.com/ipython/traitlets/blob/master/.github/workflows/downstream.yml
@jtpio
Copy link
Member Author

jtpio commented Apr 12, 2021

Downstream failures noticed in jupyter-server/jupyter_server#474

@davidbrochart
Copy link
Member

That's a good idea @jtpio, I'm going to set that up.
In the meantime the jupyter server's issue should be fixed in jupyter-server/jupyter_server#475.

@davidbrochart davidbrochart mentioned this issue Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test downstream projects davidbrochart/jupyter_client
2 participants
@jtpio @davidbrochart