Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual studio code terminal issue #95

Closed
MCWertGaming opened this issue Feb 28, 2021 · 5 comments
Closed

Visual studio code terminal issue #95

MCWertGaming opened this issue Feb 28, 2021 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MCWertGaming
Copy link
Collaborator

Hey,
i encountered some problems with cpp-terminal while working inside of visual studio code. The window class causes wrong colors on wrong parts on the screen and visual studio crashes sometimes while debugging. I will look into the cause (and will try to fix that) later on.

Here is what I mean:
image

The crash happens randomly, i'm not sure yet on how to replicate it.

@certik
Copy link
Collaborator

certik commented Feb 28, 2021

Thanks for noticing! I also use vscode. We need to fix that.

@MCWertGaming MCWertGaming mentioned this issue Mar 16, 2021
42 tasks
@MCWertGaming
Copy link
Collaborator Author

MCWertGaming commented Apr 5, 2021

I have found an fix on this problem. Using "\n" while having a custom background color results in this effect. The foreground color has no issue with this at all. So we just need to make sure that Window and Window_24bit do "\033[0m" before "'\n". 4bit and 8bit colors have the same issue.

@MCWertGaming
Copy link
Collaborator Author

I have created an issue on their github:
microsoft/vscode#120569
Also I have created a feature request on supporting more ANSI codes in the vscode integrated terminal
microsoft/vscode#120569

@MCWertGaming MCWertGaming added the bug Something isn't working label Nov 23, 2021
@MCWertGaming MCWertGaming added this to the V1.X.X milestone Dec 7, 2021
@flagarde
Copy link
Collaborator

flagarde commented Mar 19, 2023

@MCWertGaming This is solved too

//FIX maybe we need an other function without �[K if we want to modify background of part of the screen (Moving cursor and changing color )

on VScode:

@MCWertGaming
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants