Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #88

Closed
MCWertGaming opened this issue Feb 13, 2021 · 3 comments
Closed

Unit testing #88

MCWertGaming opened this issue Feb 13, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MCWertGaming
Copy link
Collaborator

The doctest.h file in the root of the repository claims to be gerated by cmake - but that's a lie. I would sugest to let it really be generated by cmake, or at least get updated every now and then. We are using 2.3.4, newest version is 2.4.5. I would remove the file and setup doctest as cmake sub-project.

Another solution would be moving to gtest (the unit testing framework, I usually use). It's basially the same but if I got it right, it can even test colors and stuff like that. I'll definietely test it a bit in terms of benefits for cpp-terminal and I understand, if you don't want to move yet. Do you know that testing framework at all?

@certik
Copy link
Collaborator

certik commented Feb 13, 2021

I just copied the doctest from upstream. That is the easiest way to get it working. I wouldn't worry about it too much.

@MCWertGaming
Copy link
Collaborator Author

I quickly wanted to note, that the latest version of doctest is not compiling on windows, [an issue on that is open since 10 days but it's not fixed yet. But the owner of the repository already answered that issue with "I'm open to PRs".
https://github.com/doctest/doctest/issues/465
Maybe we shouldn't update it yet.

@MCWertGaming MCWertGaming mentioned this issue Mar 16, 2021
42 tasks
@MCWertGaming MCWertGaming self-assigned this Dec 7, 2021
@MCWertGaming MCWertGaming added the enhancement New feature or request label Dec 7, 2021
@MCWertGaming MCWertGaming added this to the V1.0.0 milestone Dec 7, 2021
@MCWertGaming
Copy link
Collaborator Author

Moved into #182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants