You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basically moving cpp-terminal's functions between the header files so the provided set of functions makes actually sense. This will also include cutting the BaseTerminal and Terminal classes so they actually make sense.
The text was updated successfully, but these errors were encountered:
I have looked at the BaseTerminal and terminal classes and have thought about maybe split the classes into one class for preparing the terminal (base.hpp) and three functions for the input (input.cpp). The thing about moving the input into another files would be that the Windows class could call the preparation class itself int it's constructor and store it's object as private member. that would mean the user don't have to include both window.hpp and base.hpp.
The input class could be made into just functions and put into input.hpp. That would mean that we don't have to pass the object all the time to get user input. Also we don't have to include base.hpp all the time beacuse it needs to hold the Terminal class.
What do you think @certik? Is that a good idea or rather do a different approach here?
Basically moving cpp-terminal's functions between the header files so the provided set of functions makes actually sense. This will also include cutting the BaseTerminal and Terminal classes so they actually make sense.
The text was updated successfully, but these errors were encountered: