You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #3124, @ibdafna listened for window resize events as a proxy for if a root widget view needed to have a resize event triggered. This is a coarse proxy, since changing a browsers window size may or may not mean that the root widget size changed, and something else on the page may also change the root widget size and we wouldn't know if the browser window size didn't change.
That means that we can now use a ResizeObserver on each root widget DOM element instead of listening to the window resize event to give more precise triggering of this event. I'd suggest checking for the existence of ResizeObserver, and falling back to the window resize event if it doesn't exist.
In #3124, @ibdafna listened for window resize events as a proxy for if a root widget view needed to have a resize event triggered. This is a coarse proxy, since changing a browsers window size may or may not mean that the root widget size changed, and something else on the page may also change the root widget size and we wouldn't know if the browser window size didn't change.
@blois pointed out in #2605 (comment) that the standardized ResizeObserver is now pretty well supported (at least since early 2020).
That means that we can now use a ResizeObserver on each root widget DOM element instead of listening to the window resize event to give more precise triggering of this event. I'd suggest checking for the existence of ResizeObserver, and falling back to the window resize event if it doesn't exist.
The relevant code to change from #3124 is https://github.com/jupyter-widgets/ipywidgets/blob/master/packages/html-manager/src/htmlmanager.ts#L38-L45 and https://github.com/jupyter-widgets/ipywidgets/blob/master/widgetsnbextension/src/extension.js#L78-L85
The text was updated successfully, but these errors were encountered: