-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No overflow at the top level in JupyterLab #3247
Comments
The solution to this should probably be backported to 7.x. |
@jasongrout I can't reproduce this anymore. Will discuss on our call tomorrow! |
Hi @jasongrout @ibdafna, after spending a bit too long on I think the following are duplicates of this issue: #2499 #2778 #2842 #3184 #3322 #3412 Since this is a blocking issue for a lot of users (myself included, since for example this prevents using widgets showing |
In case this helps anyone wanting to do a local install: # create tmp venv w/ yarn for dev build
conda create -p /tmp/venv-widgets -c conda-forge python=3.8 yarn jupyterlab=3.2.3
conda activate /tmp/venv-widgets
git clone https://github.com/jupyter-widgets/ipywidgets && cd ipywidgets
git checkout 7.6.5
git cherry-pick 57eca692c445148cf54c7a9d05bfbf2c389b091c # https://github.com/jupyter-widgets/ipywidgets/pull/2500
# optional: bump ipywidgets/_version.py & jupyterlab_widgets/jupyterlab_widgets/_version.py
bash -x ./dev-install.sh
python setup.py bdist_wheel # build ipywidgets wheel, maybe unnecessary
cd jupyterlab_widgets && python setup.py bdist_wheel # build jupyterlab_widgets wheel
# Install wheel to venv to use
conda activate my_env
pip install {path to}/ipywidgets/dist/ipywidgets-7.6.*.whl {path to}/ipywidgets/jupyterlab_widgets/dist/jupyterlab_widgets-1.0.*.whl |
Description
The top-level widget box should scroll so you can see the overflow.
I think this may be the underlying issue for jupyterlab/jupyterlab#10763
Reproduce
On current master, execute:
Note that in JupyterLab (3.1) you cannot scroll to see the full box:
This is becaue the top-level jp-OutputArea-output div has the
jupyter-widgets
class, which masks itsoverflow:auto
withoverflow:visible
:I think recently we added the jupyter-widgets class to this top-level element, but I can't find the issue nor where in the code it happens right now.
Expected behavior
That jp-OutputArea-output div should have
overflow: auto
, and quite possibly should not have thejupyter-widgets
class applied.Context
The text was updated successfully, but these errors were encountered: