Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Text data type does not delete as expected" #68

Conversation

jbdyn
Copy link
Contributor

@jbdyn jbdyn commented Jan 19, 2024

Essentially, I adjust the conditions for range lengths such that they align with the signature of the remove_range method of TextRef in Yrs.

Additionally, I review convenience methods for text manipulation replace_range, remove_range, insert, and clear, inspired by the blog post of Darren Burns

Copy link

welcome bot commented Jan 19, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@davidbrochart
Copy link
Collaborator

Thanks for opening a PR.
What do you mean by "Text data type does not delete as expected"? Can you add a test showing that it solves an issue?

@jbdyn
Copy link
Contributor Author

jbdyn commented Jan 19, 2024

Sure!

I added an example in the corresponding issue and I am about to write tests atm.

Do you agree with the extra methods I added? Maybe I should show these changes in an extra PR. 🤔

@davidbrochart
Copy link
Collaborator

I didn't see the issue, sorry.
I'll have a look next week.

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbdyn, I left a few comments.

python/pycrdt/text.py Outdated Show resolved Hide resolved
python/pycrdt/text.py Outdated Show resolved Hide resolved
python/pycrdt/text.py Outdated Show resolved Hide resolved
python/pycrdt/text.py Show resolved Hide resolved
@jbdyn jbdyn marked this pull request as ready for review January 22, 2024 13:49
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jbdyn !

@davidbrochart davidbrochart merged commit 60f1c4a into jupyter-server:main Jan 22, 2024
16 checks passed
Copy link

welcome bot commented Jan 22, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants