-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve "Text data type does not delete as expected" #68
Resolve "Text data type does not delete as expected" #68
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
This reverts commit cebe3d5.
Thanks for opening a PR. |
Sure! I added an example in the corresponding issue and I am about to write tests atm. Do you agree with the extra methods I added? Maybe I should show these changes in an extra PR. 🤔 |
I didn't see the issue, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbdyn, I left a few comments.
The range length is computed outside/after the slice check
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jbdyn !
Essentially, I adjust the conditions for range lengths such that they align with the signature of the
remove_range
method ofTextRef
in Yrs.Additionally, I review convenience methods for text manipulation
replace_range
,remove_range
,insert
, andclear
, inspired by the blog post of Darren Burns