Raise ValueError on Doc.get_update() error (#118)

Author: davidbrochart

src/doc.rs

@@ -1,4 +1,5 @@
 use pyo3::prelude::*;
+use pyo3::exceptions::PyValueError;
 use pyo3::types::{PyBytes, PyDict, PyLong, PyList};
 use yrs::{
     Doc as _Doc,
@@ -87,7 +88,8 @@ impl Doc {
     fn get_update(&mut self, state: &PyBytes) -> PyResult<PyObject> {
         let txn = self.doc.transact_mut();
         let state: &[u8] = FromPyObject::extract(state)?;
-        let update = txn.encode_diff_v1(&StateVector::decode_v1(&state).unwrap());
+        let Ok(state_vector) = StateVector::decode_v1(&state) else { return Err(PyValueError::new_err("Cannot decode state")) };
+        let update = txn.encode_diff_v1(&state_vector);
         drop(txn);
         let bytes: PyObject = Python::with_gil(|py| PyBytes::new(py, &update).into());
         Ok(bytes)

tests/test_doc.py

@@ -203,3 +203,10 @@ def test_not_empty_update():
     events.clear()
     del text[5]
     assert events
+
+
+def test_get_update_exception():
+    doc = Doc()
+    with pytest.raises(ValueError) as excinfo:
+        doc.get_update(b"\x12")
+    assert str(excinfo.value) == "Cannot decode state"