Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base_url to routes #61

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Add base_url to routes #61

merged 1 commit into from
Nov 22, 2022

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart mentioned this pull request Nov 22, 2022
Closed
@davidbrochart davidbrochart added the bug Something isn't working label Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (40e2dd7) compared to base (0730c89).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 40e2dd7 differs from pull request most recent head ae7d34f. Consider uploading reports for the commit ae7d34f to get more accurate results

Additional details and impacted files 
@@          Coverage Diff          @@
##            main     #61   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        276     277    +1     
=====================================
- Misses       276     277    +1
Impacted Files Coverage Δ
jupyter_server_ydoc/app.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jtpio
jtpio approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

hbcarlos
hbcarlos approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @davidbrochart!

@davidbrochart davidbrochart merged commit a8d0e59 into jupyterlab:main Nov 22, 2022
@davidbrochart davidbrochart deleted the base_url branch November 22, 2022 08:13
fcollonval
fcollonval reviewed Nov 22, 2022
View reviewed changes
jupyter_server_ydoc/app.py
(r"/api/yjs/roomid/(.*)", YDocRoomIdHandler),
(r"/api/yjs/(.*)", YDocWebSocketHandler),
url_path_join(
self.settings["base_url"], (r"/api/yjs/roomid/(.*)", YDocRoomIdHandler)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct as for example this is not what is done by Jupyter Server Terminals:

https://github.com/jupyter-server/jupyter_server_terminals/blob/574e1018b7d924f09c1ca45389182f1fd314caee/jupyter_server_terminals/app.py#L72

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and it seems to be confirmed by the Binder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just yanked jupyter-server-ydoc v0.5.0 on PyPI.

davidbrochart added a commit to davidbrochart/jupyter_collaboration that referenced this pull request Nov 22, 2022
@davidbrochart
Revert jupyterlab#61
7a86933
davidbrochart added a commit to davidbrochart/jupyter_collaboration that referenced this pull request Nov 22, 2022
@davidbrochart
Revert jupyterlab#61
9604799
davidbrochart added a commit that referenced this pull request Nov 22, 2022
@davidbrochart
Revert #61 (#62)
1ce6cc3
hbcarlos pushed a commit to hbcarlos/jupyter-collaboration that referenced this pull request Jan 29, 2023
@davidbrochart @hbcarlos
Add base_url to routes (jupyterlab#61)
b7cf7ab
hbcarlos pushed a commit to hbcarlos/jupyter-collaboration that referenced this pull request Jan 29, 2023
@davidbrochart @hbcarlos
Revert jupyterlab#61 (jupyterlab#62)
318fb91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval left review comments

@hbcarlos hbcarlos hbcarlos approved these changes

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.6.0a4] Can't create a notebook with RTC enabled
4 participants
@davidbrochart @jtpio @fcollonval @hbcarlos