Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about mock schema domain names #852

Closed
afshin opened this issue May 22, 2022 · 1 comment · Fixed by #853
Closed

Question about mock schema domain names #852

afshin opened this issue May 22, 2022 · 1 comment · Fixed by #853

Comments

@afshin
Copy link
Contributor

afshin commented May 22, 2022

The project's domain name is jupyter.org. Is there a testing convention that calls for this to be .com? If not, then let's update these to either example.com or jupyter.org

(cc @3coins re: mock events in #851)

$id: event.mock.jupyter.com/message

event_bus.allowed_schemas = ["event.mock.jupyter.com/message"]

@Zsailer
Copy link
Member

Zsailer commented May 23, 2022

Ah, yes. Thanks for pointing this out. This was oversight on my part in #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants