Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-y does not confirm exit prompt #383

Closed
laundmo opened this issue Jan 13, 2021 · 4 comments
Closed

-y does not confirm exit prompt #383

laundmo opened this issue Jan 13, 2021 · 4 comments

Comments

@laundmo
Copy link

laundmo commented Jan 13, 2021

Disclaimer: this is copied from jupyterlab/jupyterlab#9585 since i was asked there to re-open here.

Description

When running jupyter lab with -y and pressing ctrl+c to stop, it still prompts for "Shutdown this jupyter server"
image

Reproduce

  1. Run jupyter lab with the -y flag
  2. Press ctrl + C to stop jupyter lab
  3. Observe it asking for a confirmation.

Expected behavior

I expect -y to skip the confirmation.

Context

Running in WSL, with a largely default config, where the only changed variables are:

c.ServerApp.browser = '/mnt/c/Program Files/Mozilla Firefox/firefox.exe'
c.ServerApp.use_redirect_file = False
  • Operating System and version: Windwos 10 + WSL Ubuntu 18
  • JupyterLab version: 3.0.2 (3.0.3 has another issue with authentication)
Command Line Output
jupyter lab --allow-root -y
[I 2021-01-09 14:42:36.621 ServerApp] jupyterlab | extension was successfully linked.
[I 2021-01-09 14:42:36.947 ServerApp] nbclassic | extension was successfully linked.
[I 2021-01-09 14:42:36.976 LabApp] JupyterLab extension loaded from /usr/local/lib/python3.6/dist-packages/jupyterlab
[I 2021-01-09 14:42:36.976 LabApp] JupyterLab application directory is /usr/local/share/jupyter/lab
[I 2021-01-09 14:42:36.979 ServerApp] jupyterlab | extension was successfully loaded.
[I 2021-01-09 14:42:36.984 ServerApp] nbclassic | extension was successfully loaded.
[I 2021-01-09 14:42:36.984 ServerApp] Serving notebooks from local directory: /mnt/d/user/Documents
[I 2021-01-09 14:42:36.984 ServerApp] Jupyter Server 1.2.1 is running at:
[I 2021-01-09 14:42:36.984 ServerApp] http://localhost:8888/lab?token=
[I 2021-01-09 14:42:36.984 ServerApp]  or http://127.0.0.1:8888/lab?token=
[I 2021-01-09 14:42:36.985 ServerApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
[C 2021-01-09 14:42:36.992 ServerApp]
To access the server, open this file in a browser:
    file:///home/l/.local/share/jupyter/runtime/jpserver-15471-open.html
Or copy and paste one of these URLs:
    http://localhost:8888/lab?token=
 or http://127.0.0.1:8888/lab?token=

[W 2021-01-09 14:42:41.264 LabApp] Could not determine jupyterlab build status without nodejs
^C[I 2021-01-09 14:42:46.580 ServerApp] interrupted
Serving notebooks from local directory: /mnt/d/lauri/Documents
0 active kernels
Jupyter Server 1.2.1 is running at:
http://localhost:8888/lab?token=
or http://127.0.0.1:8888/lab?token=
Shutdown this Jupyter server (y/[n])?

@laundmo
Copy link
Author

laundmo commented Jan 13, 2021

@jasongrout there you go, reopened here.

@jasongrout
Copy link
Contributor

Thanks! I'll close the other one since this is where development would happen.

@sparekh-bbg
Copy link

Seems like this should be closed by PR #479

@ivanov
Copy link
Contributor

ivanov commented May 7, 2021

Thanks @sparekh-bbg !

@ivanov ivanov closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants