extensions: render default templates with default static_url #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids rendering errors or incorrect URLs for error pages, which should use the base static_url function
|
Thank you, @minrk. Acknowledging this PR ❤️ Sorry for the slow reply here, was OOO the past couple of weeks. I'll look at this closer later today or Monday at the latest. |
Zsailer
approved these changes
Jul 18, 2024
|
Test failures appear unrelated. I'll look into these in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids rendering errors or incorrect URLs for error pages, which must use the base static_url function
closes #1434
A probably cleaner approach would be to attach
static_urlto jinja environment globals instead of a method on the Handler, but the compatibility implications of switching to that are more complicated than I felt comfortable tackling.