From a88e36f5d48d2f508ff6916cdd1d061abdca65a6 Mon Sep 17 00:00:00 2001 From: Oliver Sanders Date: Wed, 8 Sep 2021 15:20:34 +0100 Subject: [PATCH] pytest_plugin: fix mutable kwarg defaults --- jupyter_server/pytest_plugin.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/jupyter_server/pytest_plugin.py b/jupyter_server/pytest_plugin.py index ef88dd6bfd..821c7c95d0 100644 --- a/jupyter_server/pytest_plugin.py +++ b/jupyter_server/pytest_plugin.py @@ -316,7 +316,11 @@ async def my_test(jp_fetch): ... """ - def client_fetch(*parts, headers={}, params={}, **kwargs): + def client_fetch(*parts, headers=None, params=None, **kwargs): + if not headers: + headers = {} + if not params: + params = {} # Handle URL strings path_url = url_escape(url_path_join(*parts), plus=False) base_path_url = url_path_join(jp_base_url, path_url) @@ -358,7 +362,11 @@ async def my_test(jp_fetch, jp_ws_fetch): ... """ - def client_fetch(*parts, headers={}, params={}, **kwargs): + def client_fetch(*parts, headers=None, params=None, **kwargs): + if not headers: + headers = {} + if not params: + params = {} # Handle URL strings path_url = url_escape(url_path_join(*parts), plus=False) base_path_url = url_path_join(jp_base_url, path_url)