Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs generated from a fork cannot run check_release #9

Closed
afshin opened this issue Apr 28, 2021 · 0 comments · Fixed by #10
Closed

PRs generated from a fork cannot run check_release #9

afshin opened this issue Apr 28, 2021 · 0 comments · Fixed by #10
Labels
bug Something isn't working

Comments

@afshin
Copy link
Contributor

afshin commented Apr 28, 2021

PRs generated from a fork cannot run check_release as of now

  • We need to separate the branch parameter into ref (the source reference) and target (the target branch) since the branch does not exist on the target repo.
  • We cannot make draft GitHub releases because we have a read-only token. Technically we can run the workflow on the forked repository but it would not be visible to a reviewer of a pull request.
  • So, check_release needs to be modified to build assets, check them, and publish them (using the local pypi server and npm --dry-run, and bypass any GitHub release activity.
@afshin afshin added the bug Something isn't working label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant