Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables for image_name and executor_image_name not taking precedence #135

Open
vegetablest opened this issue Dec 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vegetablest
Copy link

Description

The environment variables GP_IMAGE_NAME and GP_EXECUTOR_IMAGE_NAME do not take precedence over configuration defaults when launching container-based kernels.

Reproduce

import os
from uuid import uuid4

from jupyter_client.manager import KernelManager

os.environ['JUPYTER_DEFAULT_PROVISIONER_NAME'] = 'kubernetes-provisioner'
os.environ['KERNEL_NAMESPACE'] = 'default'
os.environ['GP_IMAGE_NAME'] = 'my-image'

km = KernelManager(kernel_name="k8s_python")

km.start_kernel(kernel_id=str(uuid4()))

Expected Behavior

Environment variables should take precedence over configuration defaults to allow flexible runtime overrides.

Context

  • Operating System and version: Debian GNU/Linux 12
  • gateway_provisioners : 0.4.0
  • jupyter_client: 8.6.2
  • jupyter_server: 2.14.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant