Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Do you need two separate discriminators? #92

Open
pfeatherstone opened this issue Dec 1, 2020 · 2 comments
Open

Question: Do you need two separate discriminators? #92

pfeatherstone opened this issue Dec 1, 2020 · 2 comments

Comments

@pfeatherstone
Copy link

I get similar-ish results when using the same discriminator for both cVAE-GAN and cLR-GAN.
Is this a happy coincidence and a strike of luck? Is there some theoretical backing for having 2 discriminators?

@pfeatherstone
Copy link
Author

Just noticed the option use_same_D. Did that produce good results for you?

@SanderGielisse
Copy link

Really wondering this too, the paper claims results were slightly better with two separate discriminators. However, because of #93 I am actually still unsure if the implementation for use_same_D is correct. If I understand #93 correctly, the discriminator when using use_same_D only receives half the updates, which makes me think this is where the findings that two separate discriminators are better came from. Anyone who could please provide some clarification on both this issue and #93? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants