Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't authenticate to RiotClientUx #106

Open
plonsik opened this issue Mar 13, 2023 · 7 comments
Open

Can't authenticate to RiotClientUx #106

plonsik opened this issue Mar 13, 2023 · 7 comments

Comments

@plonsik
Copy link

plonsik commented Mar 13, 2023

Hey, I wanted to authenticate with RiotClientUx, but after specified it in authenticate name: "RiotClientUx" im getting "league client process could not be located". I've noticed that there is no RiotClientUx process launched, only LeagueClientUx and LeagueClient with commands suggests that RiotClient is bundled into it? Im not really sure.
process

@plonsik
Copy link
Author

plonsik commented Mar 13, 2023

I think the issue here is that we need to change regex when we are trying to connect to Riot Client but process stays the same "LeagueClientUx.exe"

if(name != DEFAULT_NAME){
  const portRegex = /--riotclient-app-port=([0-9]+)/
  const passwordRegex = /--riotclient-remoting-auth-token=([\w-]+?)(?:\s*-{2}[\w-]|\s*$)/
} else {
  const portRegex = /--app-port=([0-9]+)/
  const passwordRegex = /--remoting-auth-token=([\w-]+?)(?:\s*-{2}[\w-]|\s*$)/
}

@junlarsen
Copy link
Owner

Hi, thanks for the issue!

What does the LeagueClientUx.exe command line arguments look like? league-connect will by default try the LeagueClientUx executable, not the LeagueClient one.

@plonsik
Copy link
Author

plonsik commented Mar 15, 2023

Hello!
LeagueClientUx command line line has also riotclient credentials, just few more arguments. What im trying to point it that line in your code:

   if (!isWindows) {
      command = `ps x -o args | grep '${name}'`
    } else if (isWindows && options?.useDeprecatedWmic === true) {
      command = `wmic process where caption='${name}.exe' get commandline`
    } else {
      command = `Get-CimInstance -Query "SELECT * from Win32_Process WHERE name LIKE '${name}.exe'" | Select-Object CommandLine | fl`
    }

from authentication.ts starting at line 123

when you set in authentication parameter name to "name: "RiotClientUx"

  • it wont get credentials for RiotClient - need to have another regex as i pointed in 1st post of the issue
  • it wont find League Client - there is no process RiotClientUx only LeagueClientUx and if u want to connect to RiotClient you only need to swap port and token - every request is still sent to 127.0.0.1 but with riotclient port

Hope im clear enough, if there is something you cant understand please I'll try explaining again :D or we can do quick call also

@plonsik
Copy link
Author

plonsik commented Mar 15, 2023

LeagueClientUx command line:
"--riotclient-auth-token=nGPcMQudo7-Ub8uSNXjcww" "--riotclient-app-port=52658" "--no-rads" "--disable-self-update" "--region=EUNE" "--locale=en_GB" "--riotgamesapi-standalone" "--riotgamesapi-settings=eyJjbGllbnQtY29uZmlnIjp7InVybCI6Imh0dHBzOi8vY2xpZW50Y29uZmlnLnJwZy5yaW90Z2FtZXMuY29tIn0sImRlZmF1bHRfcmVnaW9uIjoiRVVORSIsImdsb2JhbHMiOnsic2Vzc2lvbi1pZCI6IjY4NTQ0MDVkLWY2Y2UtYzA0My1hMTQ2LTk3MTk5MjM4MDNmNSJ9LCJwYXRjaGxpbmVfaWQiOiJsaXZlIiwicHJvZHVjdC1pbnRlZ3JhdGlvbiI6eyJhcHAtdXBkYXRlLXN0YXR1cyI6IkM6L1Byb2dyYW1EYXRhL1Jpb3QgR2FtZXMvTWV0YWRhdGEvbGVhZ3VlX29mX2xlZ2VuZHMubGl2ZS9sZWFndWVfb2ZfbGVnZW5kcy5saXZlLnVwZGF0ZS1zdGF0dXMuanNvbiIsImhlYXJ0YmVhdCI6IkM6L1VzZXJzL1NlYmFzdGlhbi9BcHBEYXRhL0xvY2FsL1Jpb3QgR2FtZXMvUmlvdCBDbGllbnQvRGF0YS9TZXNzaW9ucy82ODU0NDA1ZC1mNmNlLWMwNDMtYTE0Ni05NzE5OTIzODAzZjUvbkdQY01RdWRvNy1VYjh1U05YamN3dy5oZWFydGJlYXQuanNvbiIsImxvY2tmaWxlIjoiQzovUHJvZ3JhbURhdGEvUmlvdCBHYW1lcy9NZXRhZGF0YS9sZWFndWVfb2ZfbGVnZW5kcy5saXZlL2xlYWd1ZV9vZl9sZWdlbmRzLmxpdmUubG9ja2ZpbGUiLCJzZXR0aW5ncyI6IkM6L1Byb2dyYW1EYXRhL1Jpb3QgR2FtZXMvTWV0YWRhdGEvbGVhZ3VlX29mX2xlZ2VuZHMubGl2ZS9sZWFndWVfb2ZfbGVnZW5kcy5saXZlLnByb2R1Y3Rfc2V0dGluZ3MueWFtbCJ9LCJwcm9kdWN0X2lkIjoibGVhZ3VlX29mX2xlZ2VuZHMiLCJwdWJsaXNoZXIiOiJyaW90IiwicmVnaW9uX2RhdGEiOnsiRVVORSI6eyJhdmFpbGFibGVfbG9jYWxlcyI6WyJlbl9HQiIsImNzX0NaIiwiZWxfR1IiLCJodV9IVSIsInBsX1BMIiwicm9fUk8iXSwiZGVmYXVsdF9sb2NhbGUiOiJlbl9HQiIsInJzbyI6eyJjbGllbnQiOiJsb2wifX19LCJyaW90Y2xpZW50Ijp7ImFwcC1wb3J0IjoiNTI2NTgiLCJhdXRoLXRva2VuIjoibkdQY01RdWRvNy1VYjh1U05YamN3dyJ9LCJyaW90Z2FtZXNhcGkiOnsicGVyc2lzdGVuY2UtcGF0aCI6IkM6L1VzZXJzL1NlYmFzdGlhbi9BcHBEYXRhL0xvY2FsL1Jpb3QgR2FtZXMvTGVhZ3VlIG9mIExlZ2VuZHMifSwicnNvX2F1dGgiOnsiYXV0aG9yaXphdGlvbi1rZXkiOiJldzBLSUNBZ0lDSmpiMlJsSWpvZ0lscFhUWGhQYkVJelUxaGtiV0pHVW1GUFZVVXdZa1JPZDJSWE9WUlpibFpDWkVaRmRXRllTa3BXTW5CeVlVVldNR1JzYUZwaFJ6UTFXVmhDVkdGRlNsSmtkejA5SWl3TkNpQWdJQ0FpWTI5a1pWOTJaWEpwWm1sbGNpSTZJQ0paWTJaZlRVZzNTRTV0Y2xoT2RVOVNXVkEyV21OaVRuaHJaWFZ3U3pCdFNXRm1aVVJSZUc1VFZ6TkVlV2xtTUVkWVdITlllR28xVGpOWWFGVmxPSEZNWmxSelJrMTVaRk4xY2s1bWRVVjBORXcwV0Zob1p5SU5DbjA9In19" "--plugins-mask=4" "--remoting-auth-token=Yp_rUuti8wtP8IuxgSR3xw" "--respawn-command=LeagueClient.exe" "--respawn-display-name=League of Legends" "--app-port=52792" "--install-directory=C:\Riot Games\League of Legends" "--app-name=LeagueClient" "--ux-name=LeagueClientUx" "--ux-helper-name=LeagueClientUxHelper" "--log-dir=LeagueClient Logs" "--crash-reporting=crashpad" "--crash-environment=EUN1" "--crash-pipe=\\.\pipe\crashpad_11952_PUOBPVTNOPYKSPOG" "--app-log-file-path=C:/Riot Games/League of Legends/Logs/LeagueClient Logs/2023-03-15T17-14-03_11952_LeagueClient.log" "--app-pid=11952" "--output-base-dir=C:\Riot Games\League of Legends" "--no-proxy-server" "--ignore-certificate-errors"

as you can see there are LeagueClient credentials and RiotClient credentials

@EugeneWilson
Copy link
Contributor

RiotClientUx closes once you log into League unless you manually open it back up. However, when it is open it uses --remoting-auth-token just like LeagueClientUx does. Are you instead wanting to connect to the RiotClientServices process? The Riot Client doesn't have many available endpoints, so in 99.9% of cases you will want to connect to the LCU instead.

@plonsik
Copy link
Author

plonsik commented Mar 19, 2023

No, I want to use RiotClientUx, just as mentioned as a feature of this library. In my case i need endpoint from that client, so that is 0.01% case apperently.

@junlarsen
Copy link
Owner

Does the patch from Eugene in #108 fix it? Try rc-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants