From 7aab5ebaca1d0122b294c0722e4bb3d86c255677 Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Thu, 23 Mar 2017 14:52:53 +0100 Subject: [PATCH] Add TODOs for validation handling within Jupiter TestEngine Issue: #242 --- .../junit/jupiter/engine/descriptor/JupiterTestDescriptor.java | 2 +- .../junit/jupiter/engine/extension/RepeatedTestExtension.java | 2 +- .../org/junit/jupiter/params/ParameterizedTestExtension.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/JupiterTestDescriptor.java b/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/JupiterTestDescriptor.java index ace823f76729..940974ea14d0 100644 --- a/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/JupiterTestDescriptor.java +++ b/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/JupiterTestDescriptor.java @@ -77,7 +77,7 @@ protected static String determineDisplayName(E elem Optional displayNameAnnotation = findAnnotation(element, DisplayName.class); if (displayNameAnnotation.isPresent()) { String displayName = displayNameAnnotation.get().value().trim(); - // TODO Replace logging with precondition check once we have a proper mechanism for + // TODO [#242] Replace logging with precondition check once we have a proper mechanism for // handling exceptions during the TestEngine discovery phase. Otherwise, the entire // TestEngine dies without executing anything. // diff --git a/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/RepeatedTestExtension.java b/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/RepeatedTestExtension.java index 0d7eae7002c7..516b3fba4dfe 100644 --- a/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/RepeatedTestExtension.java +++ b/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/RepeatedTestExtension.java @@ -64,7 +64,7 @@ private RepeatedTestDisplayNameFormatter displayNameFormatter(RepeatedTest repea String pattern = repeatedTest.name().trim(); - // TODO Replace logging with precondition check once we have a proper mechanism for + // TODO [#242] Replace logging with precondition check once we have a proper mechanism for // handling exceptions during the TestEngine discovery phase. // // Preconditions.notBlank(name, () -> String.format( diff --git a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestExtension.java b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestExtension.java index d28f850b6d5e..74ba360fdde1 100644 --- a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestExtension.java +++ b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestExtension.java @@ -65,7 +65,7 @@ private ParameterizedTestNameFormatter createNameFormatter(Method templateMethod ParameterizedTest parameterizedTest = findAnnotation(templateMethod, ParameterizedTest.class).get(); String name = parameterizedTest.name().trim(); - // TODO Replace logging with precondition check once we have a proper mechanism for + // TODO [#242] Replace logging with precondition check once we have a proper mechanism for // handling exceptions during the TestEngine discovery phase. // // Preconditions.notBlank(name, () -> String.format(