Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish shell support #505

Closed
jethrokuan opened this issue Feb 23, 2016 · 8 comments
Closed

fish shell support #505

jethrokuan opened this issue Feb 23, 2016 · 8 comments

Comments

@jethrokuan
Copy link

Hi,

I've gotten shell support for fish, without the need for a temp directory. My code is here:
https://github.com/jethrokuan/fzf

If someone could look through, I could merge this upstream here.

@ghost
Copy link

ghost commented Feb 23, 2016

👍 Sweet, thanks @jethrokuan

@junegunn
Copy link
Owner

Similar to #486?

@jethrokuan
Copy link
Author

@junegunn actually, yes. The PR should work. I also have #477 implemented, but it should go in line with zsh or bash.

@jethrokuan
Copy link
Author

#486 doesn't seem to support multiselect for Ctrl-t.

@ghost
Copy link

ghost commented Feb 23, 2016

I missed #486. @hauleth would you mind having a look at @jethrokuan PR too? It doesn't matter which one gets merged in the end, but it would be sweet if fish users had a more positive experience with this tool out of the box without having to resort to "plugins", etc.

@jethrokuan
Copy link
Author

@hauleth I was mistaken. No need to read into an array. #486 is good to go.

@jethrokuan
Copy link
Author

I think we can close this for now, sorry for the noise. missed #486 as well when I did this

@junegunn
Copy link
Owner

No problem, thank you for your contribution. I was waiting for the answers to my questions in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants