Add more tests

Author: odow

src/Bridges/bridge_optimizer.jl

@@ -1160,7 +1160,11 @@ function _modify_bridged_function(
     change::MOI.AbstractFunctionModification,
 )
     if is_bridged(b, ci_or_obj)
-        MOI.modify(recursive_model(b), bridge(b, ci_or_obj), change)
+        try
+            MOI.modify(recursive_model(b), bridge(b, ci_or_obj), change)
+        catch
+            MOI.throw_modify_not_allowed(ci_or_obj, change)
+        end
     else
         MOI.modify(b.model, ci_or_obj, change)
     end
@@ -1877,6 +1881,18 @@ function modify_bridged_change(
     return
 end
 
+function modify_bridged_change(
+    b::AbstractBridgeOptimizer,
+    ci_or_obj,
+    change::MOI.ScalarQuadraticCoefficientChange,
+)
+    return MOI.throw_modify_not_allowed(
+        ci_or_obj,
+        change,
+        "Cannot bridge `ScalarQuadraticCoefficientChange`.",
+    )
+end
+
 function MOI.modify(
     b::AbstractBridgeOptimizer,
     ci::MOI.ConstraintIndex,
@@ -1886,7 +1902,11 @@ function MOI.modify(
         modify_bridged_change(b, ci, change)
     else
         if is_bridged(b, ci)
-            call_in_context(MOI.modify, b, ci, change)
+            try
+                call_in_context(MOI.modify, b, ci, change)
+            catch
+                MOI.throw_modify_not_allowed(ci, change)
+            end
         else
             MOI.modify(b.model, ci, change)
         end

src/Test/test_modification.jl

@@ -1016,7 +1016,7 @@ function test_modification_incorrect_VariableIndex(
     return
 end
 
-function test_modification_scalarquadraticcoefficientchange(
+function test_modification_objective_scalarquadraticcoefficientchange(
     model::MOI.ModelLike,
     config::Config{T},
 ) where {T}
@@ -1036,3 +1036,23 @@ function test_modification_scalarquadraticcoefficientchange(
     @test MOI.get(model, attr) ≈ T(1) * x * x + T(4) * x * y
     return
 end
+
+function test_modification_constraint_scalarquadraticcoefficientchange(
+    model::MOI.ModelLike,
+    config::Config{T},
+) where {T}
+    F, S = MOI.ScalarQuadraticFunction{T}, MOI.LessThan{T}
+    @requires MOI.supports_constraint(model, F, S)
+    @requires _supports(config, MOI.modify)
+    @requires _supports(config, MOI.ScalarQuadraticCoefficientChange)
+    x = MOI.add_variable(model)
+    y = MOI.add_variable(model)
+    f = T(1) * x * x + T(1) * x * x - T(1) * x * y + T(2) * y * y - T(1) * x * y
+    c = MOI.add_constraint(model, f, MOI.LessThan(T(1)))
+    @test MOI.get(model, MOI.ConstraintFunction(), c) ≈ f
+    g = T(1) * x * x + T(-3) * x * y + T(2) * y * y
+    MOI.modify(model, c, MOI.ScalarQuadraticCoefficientChange(x, x, T(2)))
+    MOI.modify(model, c, MOI.ScalarQuadraticCoefficientChange(x, y, -T(3)))
+    @test MOI.get(model, MOI.ConstraintFunction(), c) ≈ g
+    return
+end

test/Bridges/bridge_optimizer.jl

@@ -1038,6 +1038,30 @@ function test_deleting_all_variables_in_bridged_functionize_objective()
     return
 end
 
+function test_modify_objective_scalar_quadratic_coefficient_change()
+    T = Float64
+    inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{T}())
+    model = MOI.Bridges.Objective.Slack{T}(inner)
+    x = MOI.add_variable(model)
+    MOI.set(model, MOI.ObjectiveSense(), MOI.MIN_SENSE)
+    attr = MOI.ObjectiveFunction{MOI.ScalarQuadraticFunction{T}}()
+    MOI.set(model, attr, T(1) * x * x + T(2) * x + T(3))
+    change = MOI.ScalarQuadraticCoefficientChange(x, x, T(4))
+    @test_throws MOI.ModifyObjectiveNotAllowed MOI.modify(model, attr, change)
+    return
+end
+
+function test_modify_constraint_scalar_quadratic_coefficient_change()
+    T = Float64
+    inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{T}())
+    model = MOI.Bridges.Constraint.QuadtoSOC{T}(inner)
+    x = MOI.add_variable(model)
+    c = MOI.add_constraint(model, T(1) * x * x + T(2) * x, MOI.LessThan(T(1)))
+    change = MOI.ScalarQuadraticCoefficientChange(x, x, T(4))
+    @test_throws MOI.ModifyConstraintNotAllowed MOI.modify(model, c, change)
+    return
+end
+
 end  # module
 
 TestBridgeOptimizer.runtests()