[Bridges] add more runtests (#1895)

Author: odow

src/Bridges/Constraint/bridges/indicator_sos.jl

@@ -182,21 +182,33 @@ function MOI.get(
     z = MOI.get(model, MOI.VariablePrimalStart(), bridge.z)
     w = MOI.get(model, MOI.VariablePrimalStart(), bridge.slack)
     f = MOI.get(model, attr, bridge.affine_index)
+    if any(isnothing, (z, w, f))
+        return nothing
+    end
     return [z, f - w]
 end
 
 function MOI.set(
     model::MOI.ModelLike,
     attr::MOI.ConstraintPrimalStart,
     bridge::IndicatorSOS1Bridge{T},
-    value::AbstractVector,
+    value,
 ) where {T}
     @assert length(value) == 2
     MOI.set(model, MOI.VariablePrimalStart(), bridge.z, value[1])
-    w = something(
-        MOI.get(model, MOI.VariablePrimalStart(), bridge.slack),
-        zero(T),
-    )
-    MOI.set(model, attr, bridge.affine_index, value[2] + w)
+    MOI.set(model, MOI.VariablePrimalStart(), bridge.slack, zero(T))
+    MOI.set(model, attr, bridge.affine_index, value[2])
+    return
+end
+
+function MOI.set(
+    model::MOI.ModelLike,
+    attr::MOI.ConstraintPrimalStart,
+    bridge::IndicatorSOS1Bridge{T},
+    ::Nothing,
+) where {T}
+    MOI.set(model, MOI.VariablePrimalStart(), bridge.z, nothing)
+    MOI.set(model, MOI.VariablePrimalStart(), bridge.slack, nothing)
+    MOI.set(model, attr, bridge.affine_index, nothing)
     return
 end

src/Bridges/Constraint/bridges/interval.jl

@@ -267,11 +267,16 @@ function MOI.get(
     elseif bridge.upper === nothing
         return MOI.get(model, attr, bridge.lower)
     else
-        return MOI.get(model, attr, bridge.lower) +
-               MOI.get(model, attr, bridge.upper)
+        lower = MOI.get(model, attr, bridge.lower)
+        if lower === nothing
+            return nothing
+        end
+        return lower + MOI.get(model, attr, bridge.upper)
     end
 end
 
+_split_dual_start(::Nothing) = nothing, nothing
+
 function _split_dual_start(value)
     if value < 0
         return zero(value), value

src/Bridges/Constraint/bridges/norm_one.jl

@@ -169,12 +169,26 @@ function MOI.set(
     return
 end
 
+function MOI.set(
+    model::MOI.ModelLike,
+    attr::MOI.ConstraintPrimalStart,
+    bridge::NormOneBridge{T},
+    ::Nothing,
+) where {T}
+    MOI.set.(model, MOI.VariablePrimalStart(), bridge.y, nothing)
+    MOI.set(model, attr, bridge.nn_index, nothing)
+    return
+end
+
 function MOI.get(
     model::MOI.ModelLike,
     attr::Union{MOI.ConstraintPrimal,MOI.ConstraintPrimalStart},
     bridge::NormOneBridge,
 )
     nn_primal = MOI.get(model, attr, bridge.nn_index)
+    if nn_primal == nothing
+        return nothing
+    end
     t = (nn_primal[1] + sum(nn_primal)) / 2
     d = length(bridge.y)
     x = (nn_primal[(d+2):end] - nn_primal[2:(d+1)]) / 2
@@ -190,6 +204,9 @@ function MOI.get(
     bridge::NormOneBridge,
 )
     nn_dual = MOI.get(model, attr, bridge.nn_index)
+    if nn_dual === nothing
+        return nothing
+    end
     d = length(bridge.y)
     x = nn_dual[(d+2):end] - nn_dual[2:(d+1)]
     return vcat(nn_dual[1], x)
@@ -218,3 +235,13 @@ function MOI.set(
     MOI.set(model, MOI.ConstraintDualStart(), bridge.nn_index, nn_dual)
     return
 end
+
+function MOI.set(
+    model::MOI.ModelLike,
+    ::MOI.ConstraintDualStart,
+    bridge::NormOneBridge,
+    ::Nothing,
+)
+    MOI.set(model, MOI.ConstraintDualStart(), bridge.nn_index, nothing)
+    return
+end

test/Bridges/Constraint/indicator_sos.jl

@@ -318,6 +318,24 @@ function test_getting_primal_attributes()
     return
 end
 
+function test_runtests()
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.IndicatorSOS1Bridge,
+        """
+        variables: x, z
+        [z, 2.0 * x] in Indicator{ACTIVATE_ON_ONE}(LessThan(2.0))
+        z in ZeroOne()
+        """,
+        """
+        variables: x, z, y
+        2.0 * x + 1.0 * y <= 2.0
+        z in ZeroOne()
+        [y, z] in SOS1([0.4, 0.6])
+        """,
+    )
+    return
+end
+
 end  # module
 
 TestConstraintIndicatorSOS1.runtests()

test/Bridges/Constraint/interval.jl

@@ -373,6 +373,34 @@ function test_infinite_bounds(::Type{T} = Float64) where {T<:AbstractFloat}
     return _test_interval(mock, bridged_mock, set, ci)
 end
 
+function test_runtests()
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.SplitIntervalBridge,
+        """
+        variables: x
+        x in Interval(1.0, 2.0)
+        """,
+        """
+        variables: x
+        x >= 1.0
+        x <= 2.0
+        """,
+    )
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.SplitIntervalBridge,
+        """
+        variables: x
+        3.0 * x in Interval(1.0, 2.0)
+        """,
+        """
+        variables: x
+        3.0 * x >= 1.0
+        3.0 * x <= 2.0
+        """,
+    )
+    return
+end
+
 end  # module
 
 TestConstraintSplitInterval.runtests()

test/Bridges/Constraint/ltgt_to_interval.jl

@@ -229,6 +229,54 @@ function test_GreaterOrLessToInterval_unmocked()
     return
 end
 
+function test_runtests()
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.GreaterToIntervalBridge,
+        """
+        variables: x
+        x >= 1.0
+        """,
+        """
+        variables: x
+        x in Interval(1.0, Inf)
+        """,
+    )
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.GreaterToIntervalBridge,
+        """
+        variables: x
+        2.0 * x >= 1.0
+        """,
+        """
+        variables: x
+        2.0 * x in Interval(1.0, Inf)
+        """,
+    )
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.LessToIntervalBridge,
+        """
+        variables: x
+        x <= 1.0
+        """,
+        """
+        variables: x
+        x in Interval(-Inf, 1.0)
+        """,
+    )
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.LessToIntervalBridge,
+        """
+        variables: x
+        2.0 * x <= 1.0
+        """,
+        """
+        variables: x
+        2.0 * x in Interval(-Inf, 1.0)
+        """,
+    )
+    return
+end
+
 end  # module
 
 TestConstraintToInterval.runtests()

test/Bridges/Constraint/norm_to_lp.jl

@@ -573,6 +573,32 @@ function test_conic_NormOneCone()
     return
 end
 
+function test_runtests()
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.NormOneBridge,
+        """
+        variables: t, x
+        [t, x] in NormOneCone(2)
+        """,
+        """
+        variables: t, x, y
+        [t + -1.0 * y, y + -1.0 * x, y + x] in Nonnegatives(3)
+        """,
+    )
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.NormInfinityBridge,
+        """
+        variables: t, x
+        [t, x] in NormInfinityCone(2)
+        """,
+        """
+        variables: t, x
+        [t + -1.0 * x, t + x] in Nonnegatives(2)
+        """,
+    )
+    return
+end
+
 end  # module
 
 TestConstraintNormInfinity.runtests()

test/Bridges/Constraint/scalarize.jl

@@ -208,6 +208,25 @@ function test_scalarize()
     return
 end
 
+function test_runtests()
+    MOI.Bridges.runtests(
+        MOI.Bridges.Constraint.ScalarizeBridge,
+        """
+        variables: x
+        [2.0 * x + -1.0] in Nonnegatives(1)
+        [3.0 * x + 1.0] in Nonpositives(1)
+        [4.0 * x + -5.0] in Zeros(1)
+        """,
+        """
+        variables: x
+        2.0 * x >= 1.0
+        3.0 * x <= -1.0
+        4.0 * x == 5.0
+        """,
+    )
+    return
+end
+
 end  # module
 
 TestConstraintScalarize.runtests()