-
-
Notifications
You must be signed in to change notification settings - Fork 411
Add callback_node_status #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callback_node_status #2397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2397 +/- ##
=======================================
Coverage 91.61% 91.62%
=======================================
Files 42 42
Lines 4451 4452 +1
=======================================
+ Hits 4078 4079 +1
Misses 373 373
Continue to review full report at Codecov.
|
| # see if optimize! has been called. Solutions are: | ||
| # 1) defining is_set_by_optimize = false | ||
| # 2) adding a flag to JuMP to store whether it is in a callback | ||
| # 3) adding IN_OPTIMIZE to termination_status for callbacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for 3) as 1) would not work as the CachingOptimizer will try to query from the cache.
In addition, we could have is_set_in_optimize and the CachingOptimizer checks is_set_in_optimizer || is_set_by_optimizer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might actually be easier just to have this slight work-around for callback attributes. We don't have many, and it's simpler than defining a new check with all the correct plumbing. If we have many more attributes, we can revisit this.
Closes #2123
Supported in solvers: