Fix error in RawOptimizerAttribute and improve code coverage (#437)

jump-dev · Nov 24, 2024 · 5e3aec2 · 5e3aec2
1 parent 2cbbd64
commit 5e3aec2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/MOI_wrapper.jl b/src/MOI_wrapper.jl
@@ -287,7 +287,8 @@ end
 
 function MOI.get(model::Optimizer, p::MOI.RawOptimizerAttribute)
     if !haskey(model.options, p.name)
-        error("RawParameter with name $(p.name) is not set.")
+        msg = "RawOptimizerAttribute with name $(p.name) is not already set."
+        throw(MOI.GetAttributeNotAllowed(p, msg))
     end
     return model.options[p.name]
 end

diff --git a/test/MOI_wrapper.jl b/test/MOI_wrapper.jl
@@ -672,6 +672,16 @@ function test_manually_evaluated_primal_status()
     return
 end
 
+function test_RawOptimizerAttribute()
+    model = Ipopt.Optimizer()
+    attr = MOI.RawOptimizerAttribute("print_level")
+    @test_throws MOI.GetAttributeNotAllowed{typeof(attr)} MOI.get(model, attr)
+    @test MOI.supports(model, attr)
+    MOI.set(model, attr, 0)
+    @test MOI.get(model, attr) == 0
+    return
+end
+
 end  # module TestMOIWrapper
 
 TestMOIWrapper.runtests()