Skip to content

Commit 2eef56a

Browse files
committed
add instructions for contributions
1 parent abe3761 commit 2eef56a

File tree

2 files changed

+64
-0
lines changed

2 files changed

+64
-0
lines changed

Diff for: CONTRIBUTING.md

+58
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
Contributing
2+
============
3+
4+
Please follow [Github Flow](https://guides.github.com/introduction/flow/index.html).
5+
6+
This is a rough outline of the workflow:
7+
8+
* Create a topic branch from where you want to base your work. This is usually master.
9+
* Make commits of logical units.
10+
* Make sure your commit messages are in the proper format (see below).
11+
* Push your changes to a topic branch in your fork of the repository.
12+
* Submit a pull request.
13+
* Rebase and force-push to your fork's branch as necessary.
14+
15+
Thanks for you contributions!
16+
17+
18+
Commit message
19+
--------------
20+
21+
We follow a rough convention for commit messages borrowed from Angularjs. This
22+
is an example of a commit:
23+
24+
add a cluster test command
25+
26+
this uses tmux to setup a test cluster that you can easily kill and
27+
start for debugging.
28+
29+
To make it more formal it looks something like this:
30+
31+
<subject>
32+
<BLANK LINE>
33+
<body>
34+
<BLANK LINE>
35+
<footer>
36+
37+
The first line is the subject and should not be longer than 70 characters, the
38+
second line is always blank and other lines should be wrapped at 80 characters.
39+
This allows the message to be easier to read on github as well as in various
40+
git tools.
41+
42+
* The **subject** line contains succinct description of the change.
43+
- use imperative, present tense: **change**, not *changed* nor *changes*
44+
- don't capitalize first letter
45+
- no dot (.) at the end
46+
- max 70 chars
47+
48+
* The **body** describes *why* the change is necessary.
49+
- like `<subject>`, use imperative, present tense
50+
- include motivation for the change and contrasts with previous behavior
51+
- wrap lines at 72 chars when possible
52+
53+
54+
More details on commits
55+
-----------------------
56+
57+
For more details see the [angularjs commit style guide]
58+
(https://docs.google.com/a/coreos.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#).

Diff for: README.md

+6
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ You can push the built image to a private docker registry:
8484
docker push registry_id/your_id/hooktftp
8585

8686

87+
Contribute
88+
----------
89+
90+
See [`CONTRIBUTING.md`](CONTRIBUTING.md) in this repo.
91+
92+
8793
License
8894
-------
8995

0 commit comments

Comments
 (0)