changed dojox.math to follow the simple AMD transform pattern applied to dojo and dijit. it seems that it might be premature to try and refactor the code more than this.

effectively, this commit rolled back dojox.math to before r23089 and manually converted to AMD in a way similar to the automatic conversion done to dojo and dijit.  !strict. fixes #11911

Author: neonstalwart

math/BigInteger-ext.js

@@ -1,14 +1,17 @@
-define("dojox/math/BigInteger-ext", ["dojo", "dojox/math/BigInteger"], function (dojo, BigInteger) {
-	dojo.experimental("dojox.math.BigInteger-ext");
-	
-	// Contributed under CLA by Tom Wu
-	
-	// Extended JavaScript BN functions, required for RSA private ops.
-
-	var nbi = BigInteger._nbi, nbv = BigInteger._nbv,
+// AMD-ID "dojox/math/BigInteger-ext"
+define(["dojo", "dojox", "dojox/math/BigInteger"], function(dojo, dojox) {
+dojo.experimental("dojox.math.BigInteger-ext");
+
+// Contributed under CLA by Tom Wu
+
+// Extended JavaScript BN functions, required for RSA private ops.
+
+(function(){
+	var BigInteger = dojox.math.BigInteger,
+		nbi = BigInteger._nbi, nbv = BigInteger._nbv,
 		nbits = BigInteger._nbits,
 		Montgomery = BigInteger._Montgomery;
-	
+
 	// (public)
 	function bnClone() { var r = nbi(); this._copyTo(r); return r; }
 
@@ -650,6 +653,8 @@ define("dojox/math/BigInteger-ext", ["dojo", "dojox/math/BigInteger"], function
 	// int hashCode()
 	// long longValue()
 	// static BigInteger valueOf(long val)
-	
-	return BigInteger;
+
+})();
+
+return dojox.math.BigInteger;
 });

math/BigInteger.js

@@ -1,15 +1,16 @@
-define("dojox/math/BigInteger", ["dojo"], function (dojo) {
-	// export to DojoX
-	var dm = dojo.getObject("dojox.math", true);
-	
-	dojo.experimental("dojox.math.BigInteger");
-	
-	// Contributed under CLA by Tom Wu <[email protected]>
-	// See http://www-cs-students.stanford.edu/~tjw/jsbn/ for details.
-	
-	// Basic JavaScript BN library - subset useful for RSA encryption.
-	// The API for dojox.math.BigInteger closely resembles that of the java.math.BigInteger class in Java.
-	
+// AMD-ID "dojox/math/BigInteger"
+define(["dojo", "dojox"], function(dojo, dojox) {
+dojo.getObject("math.BigInteger", true, dojox);
+dojo.experimental("dojox.math.BigInteger");
+
+// Contributed under CLA by Tom Wu <[email protected]>
+// See http://www-cs-students.stanford.edu/~tjw/jsbn/ for details.
+
+// Basic JavaScript BN library - subset useful for RSA encryption.
+// The API for dojox.math.BigInteger closely resembles that of the java.math.BigInteger class in Java.
+
+(function(){
+
 	// Bits per digit
 	var dbits;
 
@@ -572,17 +573,19 @@ define("dojox/math/BigInteger", ["dojo"], function (dojo) {
 		// "constants"
 		ZERO:	nbv(0),
 		ONE:	nbv(1),
-		
+
 		// internal functions
 		_nbi: nbi,
 		_nbv: nbv,
 		_nbits: nbits,
-		
+
 		// internal classes
 		_Montgomery: Montgomery
 	});
 
-	dm.BigInteger = BigInteger;
-	
-	return BigInteger;
+	// export to DojoX
+	dojox.math.BigInteger = BigInteger;
+})();
+
+return dojox.math.BigInteger;
 });

math/_base.js

@@ -1,7 +1,10 @@
-define("dojox/math/_base", ["dojo"], function (dojo) {
-	var m = dojo.getObject("dojox.math", true);
-	
-	dojo.mixin(m, {
+// AMD-ID "dojox/math/_base"
+define(["dojo", "dojox"], function(dojo, dojox) {
+dojo.getObject("math", true, dojox);
+
+(function(){
+	var m = dojox.math;
+	dojo.mixin(dojox.math, {
 		toRadians: function(/* Number */n){
 			//	summary:
 			//		Convert the passed number to radians.
@@ -79,7 +82,7 @@ define("dojox/math/_base", ["dojo"], function (dojo) {
 		permutations: function(/* Number */n, /* Number */k){
 			//	summary:
 			//	TODO
-			if(n==0 || k==0){ 
+			if(n==0 || k==0){
 				return 1; 	// Number
 			}
 			return this.factorial(n) / this.factorial(n-k);
@@ -88,7 +91,7 @@ define("dojox/math/_base", ["dojo"], function (dojo) {
 		combinations: function(/* Number */n, /* Number */r){
 			//	summary:
 			//	TODO
-			if(n==0 || r==0){ 
+			if(n==0 || r==0){
 				return 1; 	//	Number
 			}
 			return this.factorial(n) / (this.factorial(n-r) * this.factorial(r));	// Number
@@ -155,6 +158,7 @@ define("dojox/math/_base", ["dojo"], function (dojo) {
 			return m;	//	Array
 		}
 	});
-	
-	return m;
+})();
+
+return dojox.math;
 });