-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment replacing Scalaz by Cats dependency #235
Comments
see https://github.com/julien-truffaut/Monocle/tree/cats next step: release a snapshot |
1.3.0-cats-SNAPSHOT published for 2.10 and 2.11 |
just to clarify, monocle will only move to cats once it reaches a stable version (probably 1.0). |
👍 |
Is this only on github or has it been published to sonatype/bintray? |
@stew Must be something dodgy with my own sbt resolvers then. Thanks! EDIT I found the issue pretty quickly and should have noticed it from the file output earlier. I had forgotten to add the sonatype resolvers to one of the subprojects which was dependent on another subproject which was dependent on |
I think it would be better to have Monocle not depend on either Cats or Scalaz and have modules for both available. I think in the past the reliance on |
Btw, it's less of a deal for a user of A to have Monocle introduce an otherwise-unused B to the classpath (where (A,B)∈{ (cats,scalaz), (scalaz,cats) }) in JVM-land than it is in Scala.JS-land. Under Scala.JS it's a Big Deal because it significantly increases the output JS size which website visitors must all download, and the traffic must be paid for by host and clients. |
I understand dependencies are more of an issue in js world. However, scalaz or cats are central to a library like Monocle e.g. I am more than open to discuss if / when shall we transition to cats but I believe we need one of the two dependency. |
@julien-truffaut what do you think of initiatives like shims? |
@lvicentesanchez I didn't know about it but after a quick look it seems less than complete. Also it doesn't solve the problem of |
Does the newly right-biased Either in 2.12 solve the / vs Xor problem? |
Recently, we discussed going to support both scalaz and cats probably via different branches. The cats branch should use |
closed in favour of #419 |
scalaz
bycats
in corescalaz-support
module and move all optics for scalaz classes thereThe text was updated successfully, but these errors were encountered: