Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for content could have more accuracy #12

Closed
joho1968 opened this issue Nov 10, 2022 · 2 comments
Closed

Searching for content could have more accuracy #12

joho1968 opened this issue Nov 10, 2022 · 2 comments

Comments

@joho1968
Copy link

Excellent integration! 🤘

If I enable searching for content in Mattermost from Nextcloud, I see Mattermost posts matching the text, so far so good. But there are two issues here, IMHO:

  1. If the matching text is in a "private chat" between two people, I get a "Team not found" when I click on it (after being re-directed to Mattermost)
  2. If the matching text is in a "normal channel", I get sent to the channel, but not to the actual matching post.
julien-nc added a commit that referenced this issue Nov 10, 2022
julien-nc added a commit that referenced this issue Nov 10, 2022
… dashboard item subtext for direct messages

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
Copy link
Member

julien-nc commented Nov 10, 2022

  1. Quite bad implementation on the Mattermost side: the link to a "Direct messages" conversation requires a team name but none is provided in the channel information and any team name works...so I pick one randomly from the user's team list...
  2. Thankfully there are permalinks in Mattermost. They are now the link targets of the dashboard items and of the search result items ✔️ (permalinks also include a team name and we can put any valid team for a direct message 👎 )

Included in v1.0.3-2-nightly as well.

@joho1968
Copy link
Author

Good findings ... you may want to reach out to Mattermost about this, their developer community seems to be pretty active and awake in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants