-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding comment to document creates two posts #11
Comments
Indeed, sharing the link creates only 1 post, which is good :) |
Yes, it is, it's great. My point is that I think uploading the file to MM with a comment should also only create one post, not two. |
Signed-off-by: Julien Veyssier <[email protected]>
Thanks for the suggestion. Makes total sense and was not so hard-ish to implement. All files are now in the same post, comment in the same post as the files. ✔️ This is included in v1.0.3-2-nightly if you wanna try it. Otherwise, wait for the next release, coming soon. |
Oh, I didn't even try the multiple files variant; yeah, that would have been "odd" to see in action 😳 🤔 Glad you went "all the way" with this, your implementation sounds exactly like I think it should be done. Great stuff! |
Excellent integration! 🤘
If I choose to add a comment to the file I upload (not sharing link), the integration generates two posts. IMHO, it should generate one post with the text (comment) and an attachment. It makes following a thread very hard since both posts will lack context.
It seems to work differently if I choose to share the link in MM.
The text was updated successfully, but these errors were encountered: