-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate MLKit for iOS #1225
Comments
I have created a first draft/beta of a shared ios & macos implementation of the Vision API. Please see ios-vision for the current code. It is working right now, but still needs some work on some of the features like zoom control. I will update this in the comming days. |
Hello @juliansteenbakker |
I have uploaded a new version, v7.0.0-beta.2, with some fixes. Feel free to try it out! |
Just tested an integration of v7.0.0-beta.3, no issues found so-far ... looking forward to the public release! |
Hello, is there any specific date set for the general release of version 7.0.0? |
When using analyzeImage to analyze a QR code of an image, it will remain in 'await' and will not proceed further. #1244 |
Oh.... |
@topdeveloper1219 Anyone is free to use the v7 beta. As for the issue with analyze image, I'd have to look into it. But if you do find why it isn't completing after the await, feel free to submit a pull request |
mobile_scanner
currently uses MLKit on both iOS and Android.However, for iOS there is a first-party library, namely the Vision API from Apple.
We already use this implementation for MacOS.
We should switch iOS over to use that implementation, which brings a bunch of improvements.
The following checklist lists the points that we should tackle when doing this migration:
sharedDarwinSource
to share MacOS and iOS implementation details #782analyzeImage
not throw error when picking non-Qr image on iOS #1244Nice to have also:
placeholderBuilder
anderrorBuilder
callbacks forMobileScanner
have an extra argument which serves no purpose. #1256The text was updated successfully, but these errors were encountered: