Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syncGroups footgun #129

Open
julianlam opened this issue Nov 23, 2022 · 0 comments
Open

Fix syncGroups footgun #129

julianlam opened this issue Nov 23, 2022 · 0 comments
Assignees
@julianlam
Labels
bug

Comments

@julianlam
Copy link
Owner

julianlam commented Nov 23, 2022 •
edited
Loading

If no groups are selected in syncGroups, then all groups are applied. This causes unexpected behaviour when syncGroupList is enabled, as admins are very likely to accidentally shut themselves out of the ACP.

Needs upgrade script to automatically select all values if current value is nullish
@julianlam julianlam added the bug label Nov 23, 2022
@julianlam julianlam self-assigned this Nov 23, 2022
@julianlam julianlam changed the title Fix syncGroupList footgun Fix syncGroups footgun Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julianlam