Fixed code to respect "showHeader=false" #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test case? I think you can just call |
|
Will do
…On Feb 12, 2017 5:54 PM, "Julian Hyde" ***@***.***> wrote:
Can you please add a test case? I think you can just call checkScriptFile
with an input script and expected output. SqlLineArgsTest.testNull is a
good example to follow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANeMAR9jlTknpN9cyf1lyVeW65_tbtBks5rb42ygaJpZM4L-a6U>
.
|
|
@rkoshy, Are you still working on this? |
julianhyde
force-pushed
the
master
branch
2 times, most recently
from
705aee5
to
1b22c39
Compare
|
Fixed in 14d3014. Thanks @rkoshy for your PR #57, and thanks to @snuyanzin for finishing it off and adding tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.