Fix loading system properties at startup. #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2016 10:06
Previously, if you specified any 'sqlline.' properties as a system property it would cause a NPE because the SqlLine#Reflector was not set yet (it gets set in the SqlLine constructor) because the options are loaded before the constructor
|
Fixed in e1c3a82; thanks for the PR! |
|
Thanks, Jesse. Would you have any spare cycles for a sqlline release, @julianhyde? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you specified any 'sqlline.' properties as a system property it would cause a NPE because the SqlLine#Reflector was not set yet (it gets set in the SqlLine constructor) because the options are loaded before the constructor.
This adds a test around setting a simple parameter - isolation - and also includes the fix: creating the options at the same place, but lazily loading the system properties.