-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sqlline Debian package #457
Comments
Please feel free to assign to this GitHub account. -- James |
ok, I've assigned it to you |
Hi @snuyanzin, I noticed while starting on the Debian packaging that you have pushed a 1.12 tag but there is not yet a 1.12 Github release: https://github.com/julianhyde/sqlline/releases/. |
A bit of feedback on this packaging is that the newest jline lib in the Debian repos is 3.3.1 and that looks from some compilation errors to be incompatible with sqlline 1.12. There are different possible ways forward.
If the incompatibilities are cosmetic then (3) is normally the best for making progress. If the incompatibilities are deep then we have to evaluate the achievability of (1) and worst-case fall back to (2) with plans to update again. In the failed build log, there are entire classes are missing so at this stage it looks to me like the incompatibilities are probably too deep for (3) to be sensible. |
Thanks for pointing this out. Thanks for working on this
sqlline 1.5 was the latest release based on java 5 and jline 2.14.4. Probably also makes sense to double check if this version is available in Debian repos.
Unfortunately the incompatibilities are not cosmetic. There are lots of features in history, completion, highlighting which came after jline 3.3.1 and we use them |
@snuyanzin the best will be to update Debian's jline too. Just bear with me since I'll be nibbling at this task in scraps of free time, so it may drag on a little bit. |
no pressure, take your time |
I'm finally getting moving with this and I've updated JLine and sent a PR to the Debian Java Team's repo. While I figure out their process I'll start on updating sqlline's packaging. |
Current sqlline Debian package based on a very old version.
Also it's great that James Turton offered help .
More details at
https://groups.google.com/g/sqlline-dev/c/P9bk3gXvq78/m/Rv0HKOMVBAAJ?utm_medium=email&utm_source=footer
The text was updated successfully, but these errors were encountered: