Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jLine to 3.21.0 to include fix for Apple/M1 architecture #444

Closed
vvysotskyi opened this issue Oct 19, 2021 · 2 comments
Closed

Update jLine to 3.21.0 to include fix for Apple/M1 architecture #444

vvysotskyi opened this issue Oct 19, 2021 · 2 comments

Comments

@vvysotskyi
Copy link
Contributor

vvysotskyi commented Oct 19, 2021

As @cgivre noticed, SqlLine fails to start on the Apple M1 arch and fails with the following error:

Exception in thread "main" com.sun.jna.LastErrorException: [14] Bad address
	at com.sun.jna.Native.invokeVoid(Native Method)
	at com.sun.jna.Function.invoke(Function.java:415)
	at com.sun.jna.Function.invoke(Function.java:361)
	at com.sun.jna.Library$Handler.invoke(Library.java:265)
	at com.sun.proxy.$Proxy0.ioctl(Unknown Source)
	at org.jline.terminal.impl.jna.osx.OsXNativePty.getSize(OsXNativePty.java:82)
	at org.jline.terminal.impl.AbstractPosixTerminal.getSize(AbstractPosixTerminal.java:60)
	at org.jline.terminal.Terminal.getWidth(Terminal.java:196)
	at sqlline.SqlLine.getConsoleReader(SqlLine.java:594)
	at sqlline.SqlLine.begin(SqlLine.java:511)
	at sqlline.SqlLine.start(SqlLine.java:267)
	at sqlline.SqlLine.main(SqlLine.java:206)

The issue is in jLine, and was fixed in 3.21.0 (jline/jline3@fd2589f) which was released 12 hours ago, so it will appear soon in maven central;

@vvysotskyi vvysotskyi changed the title Update jLine to 3.21.0 to fix https://github.com/jline/jline3/issues/687 Update jLine to 3.21.0 to include fix for https://github.com/jline/jline3/commit/fd2589f7818d2b0ba1d88fc9011c657f92824ff8 Oct 19, 2021
@vvysotskyi vvysotskyi changed the title Update jLine to 3.21.0 to include fix for https://github.com/jline/jline3/commit/fd2589f7818d2b0ba1d88fc9011c657f92824ff8 Update jLine to 3.21.0 to include fix for Apple/M1 architecture Oct 19, 2021
@snuyanzin
Copy link
Collaborator

+1

just for the history: there was an issue jline/jline3#699 between 3.18.0 and 3.21.0 that fails some sqlline's tests for completion.
in 3.21.0 it has been fixed => should not be an issue to make update

@snuyanzin
Copy link
Collaborator

merged at a3029aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants