Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!reconnect does not respect fastconnect property #327

Closed
snuyanzin opened this issue Jul 18, 2019 · 3 comments
Closed

!reconnect does not respect fastconnect property #327

snuyanzin opened this issue Jul 18, 2019 · 3 comments

Comments

@snuyanzin
Copy link
Collaborator

The test case

  1. connect to db (fastconnect property is true by default)
  2. !set fastconnect false
  3. !reconnect
    It will not retrieve table/column names for completion.
    To have it retrieved it is required to close connection and open again.
@snuyanzin snuyanzin mentioned this issue Jul 18, 2019
Closed
@snuyanzin
Copy link
Collaborator Author

Merged as b3a2877

@julianhyde
Copy link
Owner

Can you please give me chance to review PRs?

@snuyanzin
Copy link
Collaborator Author

Sorry. The PRs were submitted about 3 days ago and I was confused a bit with your message (to calcite dev) about no review for a week.
From the other side I would like to continue with #331.
For that reason to eliminate conflicts especially in tests I did merge.

Should I notify next time if I need to do some merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SQLLINE-327] !reconnect should respect fastconnect property value snuyanzin/sqlline
2 participants
@snuyanzin @julianhyde