!metadata keeps silence in case of wrong method arguments

[snuyanzin]

For instance each of the next lines has no output (as getTables requires 4 arguments)

0: jdbc:postgresql://...> !metadata getTables
0: jdbc:postgresql://...> !metadata getTables %
0: jdbc:postgresql://...> !metadata getTables % %
0: jdbc:postgresql://...> !metadata getTables % % %

while the line shows all tables

0: jdbc:postgresql://...> !metadata getTables % % % %

[julianhyde]

I'm guessing that it supplies default values (e.g. empty string) for the missing parameters, but the default value isn't very useful? In which case, the new behavior would be to throw if the user doesn't supply the right number of arguments?

[snuyanzin]

I think you mean !tables, !indexes, !primarykeys and others command where it really supplies default values.
But in case of !metadata getTables or !metadata whatever based on code it looks like it does not even try to supply default values.

sqlline/src/main/java/sqlline/Reflector.java

Line 62 in 36ce75d

if (ptypes.length != args.size()) {

It checks if the number of method arguments is equal to input arguments otherwise it does not go further.

[snuyanzin]

Merged as 36cb512