[SQLLINE-248] Extract into a separate method the logic of switching o… #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values for completion Complete for properties values like outputformat or boolean properties. Use Application#getName2HighlightStyle for color scheme available values. Correct method sqlline.SqlLineOpts#optionCompleters to generate org.jline.builtins.Completers.RegexCompleter for !set command based on (in decreasing order of priority): 1. Customizations 2. Available values defined in BuiltInProperty 3. Type of property. Currently there is completion only for boolean type with completion values from sqlline.SqlLineProperty#BOOLEAN_VALUES Add javadoc for sqlline.SqlLineOpts#optionCompleters Add tests for completions. Add test for !reset properties command.
…ff SqlLineParser while reading user answer
|
@snuyanzin Could we please merge this sooner than later? |
swaroopak
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR extracts into a separate method the common logic allowing a user to confirm/reject actions without SqlLineParser side effects
partially fixes #248