Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra confirmation step for destructive commands like Drop/Delete to avoid accidental executions #239

Closed
swaroopak opened this issue Dec 27, 2018 · 3 comments
Closed

Add extra confirmation step for destructive commands like Drop/Delete to avoid accidental executions #239

swaroopak opened this issue Dec 27, 2018 · 3 comments

Comments

@swaroopak
Copy link

  • Add a confirmation step before running drop/delete commands through SQL line.

  • Pass a flag to invoke above-mentioned behavior so that existing behavior is still valid.
@julianhyde
Copy link
Owner

That's a neat idea. I'd love to see a pull request for this.

@swaroopak
Copy link
Author

@julianhyde Could you provide a final review on #263

I have fixed previous comments etc.
cc: @snuyanzin

@julianhyde
Copy link
Owner

Fixed in c83414f, PR #263. Thanks for the PR, @swaroopak!

@julianhyde julianhyde mentioned this issue Mar 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julianhyde @swaroopak