Release 1.6

[julianhyde]

Release 1.6.

[julianhyde]

@snuyanzin and @arina-ielchiieva, I started a discussion thread at https://groups.google.com/forum/#!topic/sqlline-dev/VqenCiW0dg4. As you're the most active contributors, can you please join the discussion? I can add you to the mailing list if you're not already a member.

I am adopting an Apache-style vote for this release, so I will need your participation!

[snuyanzin]

Thank you for starting discussion about 1.6 release.
I put my +1 message there

[arina-ielchiieva]

+1

[julianhyde]

@snuyanzin I've committed quite a few of your PRs. PR #198 is still to do. What's left before we can make a release candidate?

[snuyanzin]

@julianhyde thank you very much for merging!
It would be great to have #196 merged too as it allows to connect even with problem drivers.
The others are just nice to have.

P.S. I rebased PRs to have conflicts resolved

[snuyanzin]

And I guess #207 (PR #208 to fix it) is one of the first issues related to release candidate

[julianhyde]

OK, done #207 and its PR #208. Also done #198. Will do #196 shortly.

Can we do a release candidate?

[snuyanzin]

Thank you very much!

Can we do a release candidate?

Yes, I think so

[julianhyde]

Can you review/revise release notes: https://github.com/julianhyde/sqlline/blob/branch-1.6/HISTORY.md

[snuyanzin]

Thank you for release notes.

I found one misprint in it and one more in commit message 9448b38, which I guess is used in release notes. Does it make sense to make a force-push with its correction?

Moreover I added to release notes more properties which were added during the release and made them ordered. #209

I still didn't test sqlline 1.6 itself, will do it today

[julianhyde]

Thanks; I merged your changes as 2b3bee4.

I think 9448b38 is too far back to force-push; it's good enough that we've fixed the typo in the release notes.

[snuyanzin]

About testing

1. Checked connectivity with Apache Cassandra, Apache Hive, Apache Calcite, H2 and it works ok
2. Checked different prompt's configurations
3. Simple queries work ok and highlighted except cases described below
4. At the moment there have been found the next issues:
   • docbkx-maven-plugin: Connection reset #210 - perhaps impacts only machines in Russia, but not 100% sure
   • NumberFormatException: For input string: "!connect jdbc" when upgrading to SQLLine 1.6 #211 - there is an already merged PR ([JLINE3-332] Throw IllegalArgumentException in case there is no times… jline/jline3#333) to jline3 to have correct exception message for all cases
   • Syntax highlighting does not work for !sql, !all commands #213 - there is a PR [SQLLINE-213] Correct detection if an input line is sql or not to hig… #214 to fix syntax highlighting for !sql, !all commands and additional tests for highlighting of queries with these commands
   • !metadata 1 shows all declared methods #215 - looks like very old but not found issue

[julianhyde]

Can someone also check that it builds and runs on Windows?

[snuyanzin]

yes, forgot to mention
connectivity to Cassandra was checked on Windows, connectivity to Hive on HDP image.

I checked it at appveoyr on JDK8, 9, 10 and it is built on Windows, here it is a link https://ci.appveyor.com/project/snuyanzin/sqlline/builds/20428249

[snuyanzin]

The only issue I faced with Windows (cmd, powershell, wsl): looks like windows terminal does support styles well bold, faint, italic and some others. Windows shells change colors a little but not text styles while in linux terminal the text could be bold, italic, etc

[julianhyde]

Am I right that #211 requires a new jline3 release? Should we hold the sqlline release for that? I think not.

Merging #215 and #213 now.

Re #210. Let's see whether it comes up when I build the release. If it doesn't, it's low priority. It is kind of crazy that docbook generation won't work offline. Maybe we can use a DTD in a local file.

And I think we're good to go. I'll build an RC and start a vote. If there are issues then we can always have another RC.

[snuyanzin]

Am I right that #211 requires a new jline3 release? Should we hold the sqlline release for that? I think not.

Yes you are right, it requires a new jline3 release but it does not look like as a blocker.

And I think we're good to go. I'll build an RC and start a vote. If there are issues then we can always have another RC.

agree

[julianhyde]

I've started a vote: https://groups.google.com/forum/#!topic/sqlline-dev/SWHPzpyBwv0

[julianhyde]

By the way, @snuyanzin are you on twitter? I'd like to tag your user name when I promote this release.

[snuyanzin]

Thank you, I started to test the RC

Yes I am on twitter, but I use it not very often but I like the idea to use it to promote for instance sqlline, Calcite.

The nickname is not connected to my name
https://twitter.com/uckamello

[julianhyde]

Fixed in 8809f74.