Added @throws description for methods to fix javadoc warnings #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about this change. Neither the @throws javadoc nor the 'throws Throwable' seem to have any information content. What about removing the 'throws Throwable' clause? If the test throws, it will fail, so we will find out about it. |
snuyanzin
force-pushed
the
JAVADOC
branch
2 times, most recently
from
23e2eed
to
2e1adb6
Compare
…sTest#checkScriptFile Extract common logic for "print stream", "tmp file creation" and "sqlline begin" into separate methods
|
Thank you for your suggestion I suspect that this change will be in conflict with #165. If it is true I will do rebase after one of these PR will be merged |
|
About build fail |
|
Merged as 58e8e70. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds
@throwdescription in javadocs and fixes #161